Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript strictFunctionTypes: true #167

Merged
merged 8 commits into from
Dec 24, 2018
Merged

Typescript strictFunctionTypes: true #167

merged 8 commits into from
Dec 24, 2018

Conversation

azizhk
Copy link
Contributor

@azizhk azizhk commented Dec 21, 2018

No description provided.

@vercel
Copy link

vercel bot commented Dec 21, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #167 into master will increase coverage by 0.06%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   82.35%   82.42%   +0.06%     
==========================================
  Files          74       74              
  Lines        1020     1024       +4     
  Branches      187      187              
==========================================
+ Hits          840      844       +4     
  Misses        161      161              
  Partials       19       19
Impacted Files Coverage Δ
src/components/TimePicker.tsx 82.6% <0%> (ø) ⬆️
src/components/shared/OptionGroup.tsx 100% <100%> (ø) ⬆️
src/components/DateInput.tsx 90.47% <100%> (+0.47%) ⬆️
src/components/RadioGroup.tsx 100% <100%> (ø) ⬆️
src/components/CheckboxGroup.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33e0f22...fc39e2c. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 21, 2018 •
edited
Loading

Codecov Report

Merging #167 into master will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   82.33%   82.35%   +0.02%     
==========================================
  Files          74       74              
  Lines        1019     1026       +7     
  Branches      187      190       +3     
==========================================
+ Hits          839      845       +6     
- Misses        161      162       +1     
  Partials       19       19
Impacted Files Coverage Δ
src/components/Toast.tsx 90.9% <ø> (+0.28%) ⬆️
src/components/Modal.tsx 30% <0%> (-1.58%) ⬇️
src/components/TimePicker.tsx 82.6% <0%> (ø) ⬆️
src/components/CheckboxGroup.tsx 100% <100%> (ø) ⬆️
src/components/RadioGroup.tsx 100% <100%> (ø) ⬆️
src/components/DateInput.tsx 90.47% <100%> (+0.47%) ⬆️
src/components/shared/OptionGroup.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfa96b1...60eb357. Read the comment docs.

@ritz078
Copy link
Contributor

ritz078 commented Dec 24, 2018

will this be a breaking change ?

@azizhk
Copy link
Contributor Author

azizhk commented Dec 24, 2018

Not a breaking change. Can be merged.

@ritz078 ritz078 merged commit 8bebceb into master Dec 24, 2018
@ritz078 ritz078 deleted the strictFunctionTypes branch December 24, 2018 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritz078 ritz078 ritz078 approved these changes

@ChaitanyaGadodia ChaitanyaGadodia Awaiting requested review from ChaitanyaGadodia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azizhk @ritz078